Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Renaming instance owner #65

Merged
merged 4 commits into from
Nov 10, 2022
Merged

refactor: Renaming instance owner #65

merged 4 commits into from
Nov 10, 2022

Conversation

ravhasin
Copy link
Contributor

@ravhasin ravhasin commented Nov 9, 2022 •
edited
Loading

Describe your changes

refactor: changed instance_owner to owner

Issue ticket number and link

MLOPS-170

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have added thorough tests.

@ravhasin ravhasin changed the title Renaming instance owner refactor: Renaming instance owner Nov 9, 2022
@ravhasin ravhasin marked this pull request as ready for review November 9, 2022 12:56
michalmrazek
michalmrazek reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@michalmrazek michalmrazek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, everyting works! thank you. Just one more thing I forgot, can you please also change the cookiecutter template here https://github.com/avast/wanna-ml/blob/master/templates/sklearn/%7B%7Bcookiecutter.project_slug%7D%7D/wanna.yaml#L31 🙏

@michalmrazek michalmrazek merged commit b93e77e into master Nov 10, 2022
@michalmrazek michalmrazek deleted the Renaming_Instance_Owner branch November 10, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalmrazek michalmrazek michalmrazek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravhasin @michalmrazek