Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: windows in gihub actions #56

Merged
merged 8 commits into from
Oct 7, 2022
Merged

build: windows in gihub actions #56

merged 8 commits into from
Oct 7, 2022

Conversation

JacekHebda
Copy link
Contributor

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have added thorough tests.

@michalmrazek michalmrazek force-pushed the mlops-157 branch 3 times, most recently from 190dea5 to c50901a Compare October 3, 2022 10:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2022

Codecov Report

Base: 71.77% // Head: 71.71% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (8a0d6c7) compared to base (fd0d52b).
Patch coverage: 95.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   71.77%   71.71%   -0.07%     
==========================================
  Files          55       55              
  Lines        2590     2602      +12     
==========================================
+ Hits         1859     1866       +7     
- Misses        731      736       +5     
Impacted Files Coverage Δ
src/wanna/core/loggers/wanna_logger.py 90.90% <87.09%> (-9.10%) ⬇️
src/wanna/components/loader.py 100.00% <100.00%> (ø)
src/wanna/core/services/path_utils.py 100.00% <100.00%> (ø)
src/wanna/core/services/pipeline.py 91.30% <100.00%> (ø)
src/wanna/core/deployment/vertex_scheduling.py 91.30% <0.00%> (-1.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michalmrazek michalmrazek force-pushed the mlops-157 branch 4 times, most recently from 511c9a8 to 3c40637 Compare October 3, 2022 11:41
@michalmrazek michalmrazek force-pushed the mlops-157 branch 2 times, most recently from e2530c7 to 5b8856f Compare October 4, 2022 06:39
Copy link
Contributor

@racinmat racinmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests/deployment/test_gcp_connector.py Outdated Show resolved Hide resolved
@michalmrazek michalmrazek merged commit 65904b3 into master Oct 7, 2022
@michalmrazek michalmrazek deleted the mlops-157 branch October 7, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants