Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check on custom labels #53

Merged
merged 3 commits into from
Sep 27, 2022
Merged

feat: check on custom labels #53

merged 3 commits into from
Sep 27, 2022

Conversation

JacekHebda
Copy link
Contributor

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have added thorough tests.

@codecov-commenter
Copy link

Codecov Report

Base: 71.97% // Head: 72.02% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (64dc92b) compared to base (af2acba).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   71.97%   72.02%   +0.04%     
==========================================
  Files          55       55              
  Lines        2566     2574       +8     
==========================================
+ Hits         1847     1854       +7     
- Misses        719      720       +1     
Impacted Files Coverage Δ
src/wanna/core/utils/validators.py 67.81% <83.33%> (+1.14%) ⬆️
src/wanna/core/models/base_instance.py 100.00% <100.00%> (ø)
src/wanna/core/models/gcp_profile.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michalmrazek michalmrazek merged commit 8e82289 into master Sep 27, 2022
@michalmrazek michalmrazek deleted the mlops-154 branch September 27, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants