Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docker service improvements #119

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

jsilva
Copy link
Collaborator

@jsilva jsilva commented Mar 12, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have verified thorough tests.

@jsilva jsilva changed the base branch from master to joao/fix-import March 12, 2024 22:50
@jsilva jsilva changed the title Joao/docker service improvements feat: docker service improvements Mar 12, 2024
@jsilva jsilva marked this pull request as ready for review March 12, 2024 23:12
@jsilva jsilva force-pushed the joao/docker-service-improvements branch from 65dc370 to aa79efd Compare March 12, 2024 23:14
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 74.49%. Comparing base (a85a84c) to head (8f70cbe).

Files Patch % Lines
src/wanna/core/services/docker.py 50.00% 28 Missing ⚠️
src/wanna/core/utils/io.py 35.29% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   74.54%   74.49%   -0.06%     
==========================================
  Files          57       58       +1     
  Lines        2852     2866      +14     
==========================================
+ Hits         2126     2135       +9     
- Misses        726      731       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from joao/fix-import to master March 13, 2024 06:29
@jsilva jsilva force-pushed the joao/docker-service-improvements branch from aa79efd to 8f70cbe Compare March 13, 2024 06:56
Copy link
Contributor

@racinmat racinmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
00025-3062151697

@jsilva jsilva merged commit b706356 into master Mar 13, 2024
3 checks passed
@jsilva jsilva deleted the joao/docker-service-improvements branch March 13, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants