Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pytest, ruff and poe based buid for quicker interations #104

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

jsilva
Copy link
Collaborator

@jsilva jsilva commented Jan 4, 2024

Describe your changes

  • Increase the maximum python version to <3.12.0 due to this being a kfp setting as well
  • Replaces the build flow to a pytest driven setup
  • Runs ruff and related formating
  • No changes to the core were made

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have added thorough tests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (0.3.0-dev@1b33f8e). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff              @@
##             0.3.0-dev     #104   +/-   ##
============================================
  Coverage             ?   74.53%           
============================================
  Files                ?       57           
  Lines                ?     2835           
  Branches             ?        0           
============================================
  Hits                 ?     2113           
  Misses               ?      722           
  Partials             ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@racinmat racinmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I prefere line-length = 120.
00363-3427823291

pyproject.toml Outdated Show resolved Hide resolved
@jsilva jsilva merged commit 9fb17b1 into 0.3.0-dev Jan 5, 2024
3 checks passed
@jsilva jsilva deleted the joao/better-build-setup branch January 5, 2024 11:24
@jsilva jsilva mentioned this pull request Mar 1, 2024
5 tasks
jsilva added a commit that referenced this pull request Mar 5, 2024
* feat: Kubeflow pipelines 2.0 update (#103)

* feat: pytest, ruff and poe based buid for quicker interations (#104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants