Merge pull request #34 from avast/michal/network

fix: allow empty network for jobs
avast · Aug 24, 2022 · 1ec6f65 · 1ec6f65
2 parents 6cdd22e + 7dd4df3
commit 1ec6f65
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/wanna/core/deployment/models.py b/src/wanna/core/deployment/models.py
@@ -90,7 +90,7 @@ class JobResource(GCPResource, Generic[JOB]):
     job_payload: Dict[str, Any]
     image_refs: List[str] = []
     tensorboard: Optional[str]
-    network: str
+    network: Optional[str]
     job_config: JOB
     encryption_spec_key_name: Optional[str]
 

diff --git a/src/wanna/core/models/gcp_profile.py b/src/wanna/core/models/gcp_profile.py
@@ -14,7 +14,7 @@ class GCPProfileModel(BaseModel, extra=Extra.forbid):
     labels: Optional[Dict[str, str]]
     bucket: str
     service_account: Optional[str]
-    network: str = "default"
+    network: Optional[str]
     subnet: Optional[str]
     kms_key: Optional[str]
     docker_repository: str = "wanna"

diff --git a/src/wanna/core/services/base.py b/src/wanna/core/services/base.py
@@ -145,7 +145,7 @@ def _get_resource_network(
         project_id: str,
         push_mode: PushMode,
         resource_network: Optional[str],
-        fallback_project_network: str,
+        fallback_project_network: Optional[str],
         use_project_number: bool = True,
     ):
         resource_network = resource_network if resource_network else fallback_project_network