[36] – Team Review Changes #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Drish-xD
commented
Jul 25, 2024
•
Drish-xD
commented
- Darken current session row color.
- Add copy button to table link icons.
- Improve filter selection like hover accent.
- Remove error color from field name during error state.
- Add start/end validation with instruction about timings.
- Separate true/false toggle state color.
- Conditional display options for signup/popup forms name.
- Allow Url without https also.
- Reduce copy toast duration.
- Optional Class Batch for Quiz Sessions.
- Hide Marking Scheme.
- Minor code changes.
suryabulusu
reviewed
Jul 29, 2024
There was a problem hiding this comment.
branch link: https://ui-fixes.dauyvuo7dvzau.amplifyapp.com/?page=0&per_page=50
-
When I click on Copy: it should be the shortened link for portal / report. I'd suggest dont provide copy button upfront. We'd like them to expand, check details, and then copy.
-
when i click on edit, marking scheme and optional limits behaviour is weird. not letting me pass through / not getting copied. maybe its time we write tests for these basic operations. encode all 9 flows, mock backend maybe.
|
Removed the copy button from Table. |
suryabulusu
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.