-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[36] – Team Review Changes #71
Conversation
Drish-xD
commented
Jul 25, 2024
•
edited
Loading
edited
- Darken current session row color.
- Add copy button to table link icons.
- Improve filter selection like hover accent.
- Remove error color from field name during error state.
- Add start/end validation with instruction about timings.
- Separate true/false toggle state color.
- Conditional display options for signup/popup forms name.
- Allow Url without https also.
- Reduce copy toast duration.
- Optional Class Batch for Quiz Sessions.
- Hide Marking Scheme.
- Minor code changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
branch link: https://ui-fixes.dauyvuo7dvzau.amplifyapp.com/?page=0&per_page=50
-
When I click on Copy: it should be the shortened link for portal / report. I'd suggest dont provide copy button upfront. We'd like them to expand, check details, and then copy.
-
when i click on edit, marking scheme and optional limits behaviour is weird. not letting me pass through / not getting copied. maybe its time we write tests for these basic operations. encode all 9 flows, mock backend maybe.
Removed the copy button from Table. |