Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create collection page #5006

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Create collection page #5006

merged 2 commits into from
Dec 14, 2022

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Dec 7, 2022

Fixes #4975

Changes were made in this PR to move create collection from modal to a new page for better UX and error handling in the GUI.

admin_collection_new

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I had only one question about a small part.

app/views/admin/collections/index.html.erb Show resolved Hide resolved
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great change!

@Dananji Dananji merged commit 18b74ca into develop Dec 14, 2022
@Dananji Dananji deleted the create-collection-page branch December 14, 2022 21:34
@joncameron joncameron mentioned this pull request Feb 3, 2023
1 task
@joncameron joncameron mentioned this pull request Feb 13, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants