Skip to content

Commit

Permalink
{Docker,Jenkins}file: update go version 1.13.4
Browse files Browse the repository at this point in the history
When go modules enabled user code is not intended be in GOROOT(/go) hence
placing source code in /src. Otherwise we hit with below error:

go: inconsistent vendoring in /go/src/github.com/intel/pmem-csi:
        go.mod requires github.com/intel/pmem-csi  but vendor/modules.txt does not include it.
        run 'go mod tidy; go mod vendor' to sync
make: *** [Makefile:70: pmem-csi-driver] Error 1

Ref: golang/go#34657

Jenkinsfile: Place the pmem-csi source out of GOPATH
  • Loading branch information
avalluri committed Nov 14, 2019
1 parent 64de157 commit 68dec0e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 2 additions & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@
! test/test-config.sh
! hack/copy-modules-license.sh
! vendor/**
! go.mod
! go.sum
8 changes: 3 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ ARG SWUPD_UPDATE_ARG
ARG NDCTL_VERSION="67"
ARG NDCTL_CONFIGFLAGS="--disable-docs --without-systemd --without-bash"
ARG NDCTL_BUILD_DEPS="os-core-dev devpkg-util-linux devpkg-kmod devpkg-json-c"
ARG GO_VERSION="1.12.9"
ARG GO_VERSION="1.13.4"

#pull dependencies required for downloading and building libndctl
ARG CACHEBUST
Expand Down Expand Up @@ -78,11 +78,9 @@ FROM build as binaries

# build pmem-csi-driver
ARG VERSION="unknown"
# Beware that this copying is filtered with .dockerignore!
ADD . /go/src/github.com/intel/pmem-csi
ENV GOPATH=/go
ADD . /src/pmem-csi
ENV PKG_CONFIG_PATH=/usr/lib/pkgconfig/
WORKDIR /go/src/github.com/intel/pmem-csi
WORKDIR /src/pmem-csi
ARG BIN_SUFFIX
# Here we choose explicitly which binaries we want in the image and in
# which flavor (production or testing). The actual binary name in the
Expand Down
3 changes: 2 additions & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ pipeline {
/* last version before the 1.14 update in 28630 */
CLEAR_LINUX_VERSION_1_13 = "28620"

PMEM_PATH = "/go/src/github.com/intel/pmem-csi"
// path for placing the source to build outside of GOROOT
PMEM_PATH = "/src/pmem-csi"
REGISTRY_NAME = "cloud-native-image-registry.westus.cloudapp.azure.com"

// Per-branch build environment, marked as "do not promote to public registry".
Expand Down

0 comments on commit 68dec0e

Please sign in to comment.