Merge recursively the config #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the first-level array was merged, if two different filters were defined in different config array, only one was kept.
|
array_replace_recursive would be a better function as array_merge_recursive appends extra values to the numerical 'size' array within individual filters options arrays - this then causes an exception... |
Closed
avalanche123
added a commit
that referenced
this pull request
Aug 29, 2013
Merge recursively the config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When more than one bundle extension implement the PrependExtensionInterface to define different filter, only one is kept by the array_merge method. With array_merge_recursive, it will kept filters defined by each bundle.