Skip to content

Handle findSourceMap returning null since Node.js 18.8.0 #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Handle findSourceMap returning null since Node.js 18.8.0 #3091

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
394ed93
findSourceMap return null since Node.js 18.8.0
Brooooooklyn Aug 25, 2022
38d316f
Apply CR suggestion
Brooooooklyn Aug 25, 2022
7fd9311
Amend comment
novemberborn Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/snapshot-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,9 @@ class Manager {

const resolveSourceFile = mem(file => {
const sourceMap = findSourceMap(file);
if (sourceMap === undefined) {
// Prior to Node.js 18.8.0, the value when a source map could not be found was `undefined`.
// This changed to `null` in <https://github.com/nodejs/node/pull/43875>. Check both.
if (sourceMap === undefined || sourceMap === null) {
return file;
}

Expand Down