Remove the faking of the TTY in worker processes #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novemberborn
force-pushed
the
remove-fake-tty
branch
from
9984b3a to
52e0b12
Compare
novemberborn
force-pushed
the
remove-fake-tty
branch
from
52e0b12 to
9b5ae11
Compare
|
I just realized we can replace the global |
(If the main process has colors enabled, that is.)
novemberborn
force-pushed
the
remove-fake-tty
branch
from
9b5ae11 to
75b123d
Compare
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #2215.
I'll kick off the process for extracting the faking logic into a separate module, to be shipped before the final 3.0.0 release.