AVA fails when running test files which are actually symlinks

[novemberborn]

Per #1137, if a test pattern matches a symlink, AVA fails to run that test file.

AVA precompiles the test file in the main process. That works fine, even with symlinks. It then communicates a hash for the precompilation result to the worker process. When the test file is required the worker loads it from the precompilation cache, using the hash received from the main process.

The problem is that the hash mapping is for the symlink path, but the worker sees the resolved path instead.

This is where the worker looks up the hash:

ava/lib/process-adapter.js

Line 85 in 0f04001

const precompiled = opts.precompiled[filename];

This is where the precompiled hash mapping is prepared:

ava/api.js

Line 70 in 0f04001

precompiled[file] = hash;

Probably the best fix is to use fs.realpathSync when preparing the hash mapping in api.js.

[rnkdev]

Hi guys, this is my very first time I actually did something to an open source program.

So I followed the hint in the issue tracker and modified api.js so that the hash now uses resolved path as the key. (I hope this is as expected and I'm just not breaking everything)

I ran npm test before committing and it passed all of the tests.

I don't want to create pull request because I'm not sure if this is the right way to do it or not.

7a1a0cd

[novemberborn]

@rnkdev please do create a pull request. It's easier to provide feedback that way 😄

Your approach looks fine, just needs a test. Looking forward to the PR!