Skip to content

Tidy internals #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Tidy internals #169

merged 2 commits into from
Jan 22, 2025

Conversation

SentryMan
Copy link
Collaborator

  • rename SPIServiceManager to ServiceManager
  • move compression to serviceManager
  • Use Enum valueof for HttpMethod mapping

- rename SPIServiceManager to ServiceManager
- move compression to serviceManager
- Use Enum `valueof` for HttpMethod mapping
@SentryMan SentryMan self-assigned this Jan 22, 2025
@SentryMan SentryMan merged commit a08a8a8 into avaje:master Jan 22, 2025
4 checks passed
@SentryMan SentryMan deleted the tidy branch January 22, 2025 05:15
SentryMan added a commit to SentryMan/avaje-jex that referenced this pull request Jan 22, 2025
* tidy internals

- rename SPIServiceManager to ServiceManager
- move compression to serviceManager
- Use Enum `valueof` for HttpMethod mapping

* Update Routing.java
rbygrave added a commit that referenced this pull request Jan 26, 2025
* Error Handlers handle Throwable

It's possible that problems like IllegalAccessError may appear, causing socket hangups if unhandled

* remove unneeded generic

* Bump the dependencies group with 7 updates

Bumps the dependencies group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| io.avaje:avaje-logback-encoder | `0.9` | `0.10` |
| io.avaje:avaje-http-api | `2.9-RC7` | `2.9-RC8` |
| io.avaje:avaje-htmx-api | `2.9-RC7` | `2.9-RC8` |
| [io.avaje:avaje-http-client](https://github.com/avaje/avaje-http-client) | `2.9-RC7` | `2.9-RC8` |
| io.avaje:avaje-http-client-generator | `2.9-RC7` | `2.9-RC8` |
| io.avaje:avaje-http-jex-generator | `2.9-RC7` | `2.9-RC8` |
| [io.github.robaho:httpserver](https://github.com/robaho/httpserver) | `1.0.19` | `1.0.21` |


Updates `io.avaje:avaje-logback-encoder` from 0.9 to 0.10

Updates `io.avaje:avaje-http-api` from 2.9-RC7 to 2.9-RC8

Updates `io.avaje:avaje-htmx-api` from 2.9-RC7 to 2.9-RC8

Updates `io.avaje:avaje-http-client` from 2.9-RC7 to 2.9-RC8
- [Release notes](https://github.com/avaje/avaje-http-client/releases)
- [Commits](https://github.com/avaje/avaje-http-client/commits)

Updates `io.avaje:avaje-http-client-generator` from 2.9-RC7 to 2.9-RC8

Updates `io.avaje:avaje-http-jex-generator` from 2.9-RC7 to 2.9-RC8

Updates `io.avaje:avaje-htmx-api` from 2.9-RC7 to 2.9-RC8

Updates `io.avaje:avaje-http-client` from 2.9-RC7 to 2.9-RC8
- [Release notes](https://github.com/avaje/avaje-http-client/releases)
- [Commits](https://github.com/avaje/avaje-http-client/commits)

Updates `io.avaje:avaje-http-client-generator` from 2.9-RC7 to 2.9-RC8

Updates `io.avaje:avaje-http-jex-generator` from 2.9-RC7 to 2.9-RC8

Updates `io.github.robaho:httpserver` from 1.0.19 to 1.0.21
- [Commits](robaho/httpserver@1.0.19...1.0.21)

---
updated-dependencies:
- dependency-name: io.avaje:avaje-logback-encoder
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: io.avaje:avaje-http-api
  dependency-type: direct:production
  dependency-group: dependencies
- dependency-name: io.avaje:avaje-htmx-api
  dependency-type: direct:production
  dependency-group: dependencies
- dependency-name: io.avaje:avaje-http-client
  dependency-type: direct:development
  dependency-group: dependencies
- dependency-name: io.avaje:avaje-http-client-generator
  dependency-type: direct:production
  dependency-group: dependencies
- dependency-name: io.avaje:avaje-http-jex-generator
  dependency-type: direct:production
  dependency-group: dependencies
- dependency-name: io.avaje:avaje-htmx-api
  dependency-type: direct:production
  dependency-group: dependencies
- dependency-name: io.avaje:avaje-http-client
  dependency-type: direct:development
  dependency-group: dependencies
- dependency-name: io.avaje:avaje-http-client-generator
  dependency-type: direct:production
  dependency-group: dependencies
- dependency-name: io.avaje:avaje-http-jex-generator
  dependency-type: direct:production
  dependency-group: dependencies
- dependency-name: io.github.robaho:httpserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

* Error Handlers handle Throwable

It's possible that problems like IllegalAccessError may appear, causing socket hangups if unhandled

* Tidy internals (#169)

* tidy internals

- rename SPIServiceManager to ServiceManager
- move compression to serviceManager
- Use Enum `valueof` for HttpMethod mapping

* Update Routing.java

* handler exceptions before after filters

Now Exceptions during handler processing will not skip after handlers
-

* Update ExceptionHandler.java

* iterator

* Update ExceptionManager.java

* Tidy BaseFilterChain

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rob Bygrave <robin.bygrave@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant