Detect clash with multiple @Bean methods returning same type #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a @factory with 2 or more bean methods that return the same type, and effectively clash on qualifier name (typically missing) then make this a compilation error. The error suggests to add a @nAmed or qualifier annotation to resolve the issue. Example: ```java @factory class MyFactory { @bean BFace one() { ... } @bean BFace two() { ... } ```
|
An variation to this would be to give the So for example: @Bean BFace one() { ...... would get the default qualifier name of |
SentryMan
approved these changes
Mar 25, 2025
I don't know if other people hit this, but I did hit it yesterday accidentally myself when I was looking to inject multiple Filter's via a Factory. I'm hoping people haven't hit it because it's a bit subtle and confusing when it occurs. |
I just use avaje http for filters I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a
@Factorywith 2 or more bean methods that return the same type, and effectively clash on qualifier name (typically missing) then make this a compilation error.The error suggests to add a
@Namedor qualifier annotation to resolve the issue.Example: