Failing test for ModuleOrdering that skips the extra test module(s)

[rbygrave]

Test components in src/test that are not annotated with @TestScope go into an extra module. This module is ignored/skipped by the compiled module ordering.

A fix for this is desired.

[rbygrave]

The complied ModuleOrdering contains:

  @Override
  public void add(AvajeModule module) {
    final var index = INDEXES.get(module.getClass().getTypeName());
    if (index != null) {
      sortedModules[index] = module;
    }
  }

... so modules that are not known are effectively lost.

[rbygrave]

The fix here adds a supportsExpected method to ModuleOrdering like:

public interface ModuleOrdering extends InjectExtension {

   /**
    * Return true if ordering supports the modules passed in.
    */
   default boolean supportsExpected(List<AvajeModule> modules) {
     return true;
   }
...

.. and changes the generated code to implement this with a check that the modules passed are the ones it expects to order.

  @Override
  public boolean supportsExpected(List<AvajeModule> modules) {
    if (modules.size() != sortedModules.length) {
      return false;
    }
    return modules.stream()
            .map(m -> m.getClass().getTypeName())
            .allMatch(k -> INDEXES.containsKey(k));
  }

[SentryMan]

LGTM, but the Compiled Ordering generation is an opt-in feature that's disabled by default, so I doubt this solves the actual issue that prompted this PR

[SentryMan]

Wait, actually this might work

[rbygrave]

Compiled Ordering generation is an opt-in feature that's disabled by default, so I doubt this solves the actual issue that prompted this PR

Yes indeed - maybe there is another issue. I headed this way because it should have worked and I was able to reproduce the error this way. Hmm.

I'll include a test that wires a BeanScope in postConstruct(). Let me know if you are still happy with this perhaps.

[SentryMan]

Tests also pass when I disable the strict wiring so I'm fine with this, let's publish an RC and see if we get some feedback