Replace Class.forName with Module Check and Direct Load
#675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mechite
added a commit
to mechite/javalin
that referenced
this pull request
Nov 26, 2025
This is a hack, but I've done it a lot and personally think it could be a better way of handling optional dependencies over `Class.forName` The thing is, `Class.forName` was designed for this very use-case of optional dependencies. Javalin claims "no reflection" even in the very readme file, so there are two ways to back this claim - Remove all non-test usage of reflection entirely, opting for techniques like these (which work and in my opinion have no downsides, except that readers might be annoyed we are catching `Error`s? This even works properly in a `native-image` as well) - Remove the claim of "no reflection" Please note that I have no clue on writing idiomatic Kotlin. Related-to: avaje/avaje-http#670 (comment) Related-to: avaje/avaje-inject#932 Related-to: avaje/avaje-http#675 Signed-off-by: Mahied Maruf <contact@mechite.com>
rbygrave
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says