Skip to content

[Client] Fix async generic responses #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SentryMan merged 1 commit into from
Jul 13, 2025
Merged

[Client] Fix async generic responses #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions http-client/src/main/java/io/avaje/http/client/DHttpClientRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,35 +644,16 @@ protected HttpResponse<Void> asyncVoid(HttpResponse<byte[]> response) {
return new HttpWrapperResponse<>(response);
}

protected <E> HttpResponse<E> asyncBean(Class<E> type, HttpResponse<byte[]> response) {
protected <E> HttpResponse<E> asyncBean(Type type, HttpResponse<byte[]> response) {
afterAsyncEncoded(response);
return new HttpWrapperResponse<>(context.readBean(type, encodedResponseBody), httpResponse);
}

protected <E> E asyncBean(Type type, HttpResponse<byte[]> response) {
afterAsyncEncoded(response);
return context.readBean(type, encodedResponseBody);
}

protected <E> HttpResponse<List<E>> asyncList(Class<E> type, HttpResponse<byte[]> response) {
afterAsyncEncoded(response);
return new HttpWrapperResponse<>(context.readList(type, encodedResponseBody), httpResponse);
}

protected <E> HttpResponse<List<E>> asyncList(Type type, HttpResponse<byte[]> response) {
afterAsyncEncoded(response);
return new HttpWrapperResponse<>(context.readList(type, encodedResponseBody), httpResponse);
}

protected <E> HttpResponse<Stream<E>> asyncStream(Class<E> type, HttpResponse<Stream<String>> response) {
responseTimeNanos = System.nanoTime() - startAsyncNanos;
httpResponse = response;
context.afterResponse(this);
checkResponse(response);
final BodyReader<E> bodyReader = context.beanReader(type);
return new HttpWrapperResponse<>(response.body().map(bodyReader::readBody), httpResponse);
}

protected <E> HttpResponse<Stream<E>> asyncStream(Type type, HttpResponse<Stream<String>> response) {
responseTimeNanos = System.nanoTime() - startAsyncNanos;
httpResponse = response;
Expand Down Expand Up @@ -853,7 +834,7 @@ public String responseBody() {
return context.maxResponseBody(new String(encodedResponseBody.content(), StandardCharsets.UTF_8));
} else if (httpResponse != null && loggableResponseBody) {
final var responseBody = httpResponse.body();
return (responseBody == null) ? null : context.maxResponseBody(responseBody.toString());
return responseBody == null ? null : context.maxResponseBody(responseBody.toString());
}
return null;
}
Expand Down