-
Notifications
You must be signed in to change notification settings - Fork 15
[http-client] Reset base if an http scheme is detected #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cf6ce02
reset path if an http scheme is detected
SentryMan 7ac946f
remove extra path calls
SentryMan 25740de
Merge branch 'master' into path
SentryMan a81fca6
Update ClientMethodWriter.java
SentryMan 6e6bba8
url instead of path
SentryMan 1c0c774
back to path
SentryMan ba690bd
revert path generation
SentryMan c87cddb
Update DUrlBuilder.java
SentryMan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
http-generator-client/src/test/java/io/avaje/http/generator/client/clients/Titan.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
package io.avaje.http.generator.client.clients; | ||
|
||
public class Titan {} |
11 changes: 11 additions & 0 deletions
11
http-generator-client/src/test/java/io/avaje/http/generator/client/clients/TitanFall.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package io.avaje.http.generator.client.clients; | ||
|
||
import io.avaje.http.api.Client; | ||
import io.avaje.http.api.Get; | ||
|
||
@Client | ||
public interface TitanFall { | ||
|
||
@Get("/${titan}/${drop.point}") | ||
Titan titanfall(); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.