Only generated response status code when statusCode > 0 #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support use case that requires programmatic control of status code but non-void controller method. This might be marginal but I don't think its a negative.
SentryMan
approved these changes
Aug 8, 2023
Collaborator
SentryMan
left a comment
SentryMan
left a comment
There was a problem hiding this comment.
expecting a negative status code one of these days?
Contributor
Author
Not really. The use case is pretty marginal in that if folks need programmatic control over the statusCode then they can take complete control, use a method that takes the ServerResponse / Context, returns void ... and completely control how the response is written. This prevents any extra Its very marginal yeah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support use case that requires programmatic control of status code but non-void controller method. This might be marginal but I don't think its a negative.