(Javalin Jsonb) Add support for disableDirectWrites to NOT write directly to Jetty HttpOutput Stream #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbygrave
changed the title
Contributor
|
It would have been good to have a failing test case. Behaviour of Javalin can change and also if helps explain the change to future devs looking at why this PR came to be. |
Collaborator
Author
|
In this case, it disconnects from Javalin even more, as we skip Javalin's CompressedOutputStream and lean more on Jetty directly. Which means it's less likely for Javalin behavior changes to affect serialization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrong headers being added when body content exceeds a certain size. Also adds a flag to disable Jsonb direct writes.