Skip to content

Support Multi-Value QueryParam/Headers/Cookies #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbygrave merged 21 commits into from
Mar 1, 2023
Merged

Support Multi-Value QueryParam/Headers/Cookies #167

rbygrave merged 21 commits into from
Mar 1, 2023

Conversation

@SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Feb 27, 2023 •
edited
Loading

Got a request from discord to add this.

  • Creates a new Collection Type Handler specifically for those param types
  • adds set, list, and a collection version of withDefault method to Param Converter
  • adds new Platform Adapter method to handle multi-value parameters
  • adds new Platform Adapter method to handle map parameters
  • Can do Map<String, List<String>> for certain params.

@SentryMan SentryMan mentioned this pull request Feb 27, 2023
Merged
LoonyRules
LoonyRules reviewed Feb 27, 2023
View reviewed changes
@SentryMan
Copy link
Collaborator Author

SentryMan commented Feb 28, 2023

And I'm done, @rbygrave plz review when you get time.

@SentryMan
Copy link
Collaborator Author

SentryMan commented Mar 1, 2023 •
edited
Loading

Split HttpClient changes into it's own PR #169 (nice)

@rbygrave rbygrave added this to the 1.28 milestone Mar 1, 2023
@rbygrave rbygrave merged commit 6efb809 into avaje:master Mar 1, 2023
@SentryMan SentryMan deleted the multival branch March 1, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LoonyRules LoonyRules LoonyRules left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@SentryMan SentryMan

Labels

None yet

Projects

None yet

Milestone

1.28

Development

Successfully merging this pull request may close these issues.

3 participants

@SentryMan @LoonyRules @rbygrave