Merge pull request #259 from avaje/feature/test-profile-nima-filter-chain

Add maven test profile as activeByDefault does not work in this scenario

Author: rbygrave

.github/workflows/build.yml

@@ -33,4 +33,4 @@ jobs:
         env:
           JAVA_VERSION: ${{ matrix.java_version }}
         run: |
-          mvn clean package
+          mvn clean package -Ptest

.github/workflows/jdk-ea.yml

@@ -37,5 +37,5 @@ jobs:
     - name: Maven version
       run: mvn --version
     - name: Build with Maven
-      run: mvn clean verify package
+      run: mvn clean verify package -Ptest
 

pom.xml

@@ -44,17 +44,15 @@
     <module>http-generator-javalin</module>
     <module>http-generator-jex</module>
     <module>http-generator-client</module>
+    <module>tests</module>
   </modules>
 
   <profiles>
     <profile>
       <id>central</id>
     </profile>
     <profile>
-      <id>default</id>
-      <activation>
-        <activeByDefault>true</activeByDefault>
-      </activation>
+      <id>test</id>
       <modules>
         <module>tests</module>
       </modules>

tests/test-nima-jsonb/pom.xml

@@ -63,6 +63,13 @@
       <version>1.1</version>
       <scope>test</scope>
     </dependency>
+
+    <dependency>
+      <groupId>io.avaje</groupId>
+      <artifactId>avaje-http-helidon-generator</artifactId>
+      <version>${project.version}</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <build>

tests/test-nima-jsonb/src/main/java/org/example/TestController.java

@@ -86,9 +86,8 @@ Map<String, Object> strBody2() {
   }
 
   @ExceptionHandler
-  String exception(Exception ex) {
-
-    return "";
+  String exception(IllegalArgumentException ex) {
+    return "Err: " + ex;
   }
 
   @ExceptionHandler
@@ -105,5 +104,6 @@ void exceptionVoid(ServerResponse res) {
   @Filter
   void filter(FilterChain chain, RoutingResponse res) {
     System.err.println("do nothing lmao");
+    chain.proceed();
   }
 }

tests/test-nima-jsonb/src/test/java/org/example/TestPair.java

@@ -42,9 +42,7 @@ private static HttpRouting.Builder routing() {
 
     var hc = new HelloController();
     var hello = new HelloController$Route(hc, beanValidator, jsonb);
-   
     routing.addFeature(hello);
-    hello.setup(routing);
 
     var cr = new ThreadLocalRequestContextResolver();
     var tc = new TestController();