Skip to content

Commit 120f670

Browse files
committed
Fix Nima tests, filter chain must proceed()
1 parent bf6133f commit 120f670

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

tests/test-nima-jsonb/pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,13 @@
6363
<version>1.1</version>
6464
<scope>test</scope>
6565
</dependency>
66+
67+
<dependency>
68+
<groupId>io.avaje</groupId>
69+
<artifactId>avaje-http-helidon-generator</artifactId>
70+
<version>${project.version}</version>
71+
<scope>test</scope>
72+
</dependency>
6673
</dependencies>
6774

6875
<build>

tests/test-nima-jsonb/src/main/java/org/example/TestController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,8 @@ Map<String, Object> strBody2() {
8686
}
8787

8888
@ExceptionHandler
89-
String exception(Exception ex) {
90-
91-
return "";
89+
String exception(IllegalArgumentException ex) {
90+
return "Err: " + ex;
9291
}
9392

9493
@ExceptionHandler
@@ -105,5 +104,6 @@ void exceptionVoid(ServerResponse res) {
105104
@Filter
106105
void filter(FilterChain chain, RoutingResponse res) {
107106
System.err.println("do nothing lmao");
107+
chain.proceed();
108108
}
109109
}

tests/test-nima-jsonb/src/test/java/org/example/TestPair.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ private static HttpRouting.Builder routing() {
4242

4343
var hc = new HelloController();
4444
var hello = new HelloController$Route(hc, beanValidator, jsonb);
45-
4645
routing.addFeature(hello);
47-
hello.setup(routing);
4846

4947
var cr = new ThreadLocalRequestContextResolver();
5048
var tc = new TestController();

0 commit comments

Comments
 (0)