Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace time.After with timer; add max retry backoff #919

Merged
merged 2 commits into from
Oct 2, 2023
Merged

replace time.After with timer; add max retry backoff #919

merged 2 commits into from
Oct 2, 2023

Conversation

danlaine
Copy link

Why this should be merged

  1. We should have a reasonable max retry backoff.
  2. time.After can leak a goroutine

How this works

Add max backoff and use a timer instead of time.After

How this was tested

Existing UT

How is this documented

N/A

@danlaine danlaine self-assigned this Sep 28, 2023
@ceyonur ceyonur merged commit 1b07798 into master Oct 2, 2023
8 checks passed
@ceyonur ceyonur deleted the remove-time-after branch October 2, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyonur ceyonur ceyonur approved these changes

@darioush darioush darioush approved these changes

@aaronbuchwald aaronbuchwald Awaiting requested review from aaronbuchwald

Assignees

@danlaine danlaine

Labels
cleanup
Projects
No open projects
EVM
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danlaine @darioush @ceyonur