Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate predicate prepare storage slots function #908

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

minghinmatthewlam
Copy link

Why this should be merged

In predicate_check and state_db we were duplicating code for preparing the predicate storage slots from a transaction's access list. This PR consolidates them to a util function to make sure they're in sync and reduces duplication.

How this works

  • Creates separate file in utils predicate_slots.go
  • Create utils PreparePredicateStorageSlots function
  • Use util function for previous places.

How this was tested

n/a

How is this documented

comments in code

Copy link
Collaborator

@aaronbuchwald aaronbuchwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice change, thanks for putting this up!

@ceyonur ceyonur merged commit eb74d42 into master Sep 27, 2023
@ceyonur ceyonur deleted the prepare-predicate-utils branch September 27, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants