Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stop flow to reduce frequency of unclean shutdowns #66

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Improve stop flow to reduce frequency of unclean shutdowns #66

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b86c4f
Improve stop flow to reduce frequency of unclean shutdowns
aaronbuchwald Mar 30, 2022
e2ef31b
Update core/blockchain.go
aaronbuchwald Mar 31, 2022
603d06f
Mark TestWalletNotifications as flaky
aaronbuchwald Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions core/blockchain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,13 @@ func (bc *BlockChain) Stop() {
return
}

log.Info("Shutting down state manager")
if err := bc.stateManager.Shutdown(); err != nil {
log.Error("Failed to Shutdown state manager", "err", err)
}

// Unsubscribe all subscriptions registered from blockchain.
log.Info("Clsoing subscriptions scope")
aaronbuchwald marked this conversation as resolved.
Show resolved Hide resolved
bc.scope.Close()
log.Info("Blockchain subscriptions closed")

Expand All @@ -534,10 +540,6 @@ func (bc *BlockChain) Stop() {
bc.wg.Wait()
log.Info("Blockchain waitgroup stopped")

if err := bc.stateManager.Shutdown(); err != nil {
log.Error("Failed to Shutdown state manager", "err", err)
}

log.Info("Blockchain stopped")
}

Expand Down