Bump avago subnet #800
Bump avago subnet #800
Conversation
iansuvak
requested review from
geoff-vball,
bernard-avalabs,
michaelkaplan13,
cam-schultz,
mdelle1 and
ylg-avalabs
| @@ -73,6 +73,8 @@ cp ${BASEDIR}/subnet-evm/subnet-evm ${BASEDIR}/avalanchego/plugins/srEXiWaHuhNyG | |||
| echo "Copied ${BASEDIR}/subnet-evm/subnet-evm binary to ${BASEDIR}/avalanchego/plugins/" | |||
|
|
|||
| export AVALANCHEGO_BUILD_PATH=$BASEDIR/avalanchego | |||
| export AVALANCHEGO_PATH=$AVALANCHEGO_BUILD_PATH/avalanchego | |||
There was a problem hiding this comment.
Is this something we can change? Building into $BASEDIR/avalanchego/avalanchego seems a little confusing
There was a problem hiding this comment.
The actual location of the build is the same as it was before. ~/.teleporter-deps/avalanchego/avalanchego where the final avalanchego is the actual binary but the folder also contains a plugins subfolder with the subnet-evm binary there.
The only difference here is that instead of passing that path in the code to tmpnet we now set it as a env variable that tmpnet reads.
| @@ -23,18 +23,18 @@ import ( | |||
| nativeMinter "github.com/ava-labs/icm-contracts/abi-bindings/go/INativeMinter" | |||
| "github.com/ava-labs/icm-contracts/tests/interfaces" | |||
| gasUtils "github.com/ava-labs/icm-contracts/utils/gas-utils" | |||
| ethereum "github.com/ava-labs/libevm" | |||
There was a problem hiding this comment.
importing libevm and ethereum seems slightly strange to me, but not pressed about it either way
There was a problem hiding this comment.
This is the pattern used inside subnet-evm for imports of libevm top level exports.
Why this should be merged
Updates dependencies in testing to the current versions.
How this works
libevminstead ofgo-ethereumHow this was tested
CI
How is this documented