Remove Warp Integration #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlawt
commented
Apr 23, 2024
| @@ -436,19 +432,19 @@ var _ = ginkgo.Describe("[Tx Processing]", func() { | |||
| // read: 2 keys reads, 1 had 0 chunks | |||
| // allocate: 1 key created with 1 chunk | |||
| // write: 2 keys modified (new + old) | |||
| transferTxConsumed := fees.Dimensions{191, 7, 12, 25, 26} | |||
| transferTxConsumed := fees.Dimensions{187, 7, 12, 25, 26} | |||
There was a problem hiding this comment.
Removed https://github.com/ava-labs/hypersdk/blob/203e78b7c65a8b7c875fa4941f974292ce989f52/chain/transaction.go#L76C9-L76C17 which returns an int which is 4 bytes
Which also resulted in updating the numbers below this line for the rest of the file as well
wlawt
commented
Apr 23, 2024
| @@ -437,19 +432,19 @@ var _ = ginkgo.Describe("[Tx Processing]", func() { | |||
| // read: 2 keys reads, 1 had 0 chunks | |||
| // allocate: 1 key created | |||
| // write: 1 key modified, 1 key new | |||
| transferTxConsumed := fees.Dimensions{227, 7, 12, 25, 26} | |||
| transferTxConsumed := fees.Dimensions{223, 7, 12, 25, 26} | |||
There was a problem hiding this comment.
same comment as above
wlawt
force-pushed
the
remove-warp
branch
6 times, most recently
from
419f8d1 to
e8e6b68
Compare
| @@ -350,8 +350,6 @@ func SetAsset( | |||
| copy(v[consts.Uint16Len+symbolLen+consts.Uint8Len+consts.Uint16Len:], metadata) | |||
| binary.BigEndian.PutUint64(v[consts.Uint16Len+symbolLen+consts.Uint8Len+consts.Uint16Len+metadataLen:], supply) | |||
| copy(v[consts.Uint16Len+symbolLen+consts.Uint8Len+consts.Uint16Len+metadataLen+consts.Uint64Len:], owner[:]) | |||
| b := byte(0x0) | |||
There was a problem hiding this comment.
You still need to reduce the size of the allocation of v above ^
| // Proceed with normal verification | ||
| return b.verify(ctx, stateReady) | ||
| } | ||
|
|
||
| // implements "snowman.Block" | ||
| func (b *StatelessBlock) Verify(ctx context.Context) error { |
There was a problem hiding this comment.
We may want to unify Build/build and Verify/verify for now but not sure where we use them.
patrick-ogrady
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #855