Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chain] Defer State Root Generation #425

Merged
merged 33 commits into from
Sep 1, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
b15e137
add first todo
patrick-ogrady Aug 27, 2023
5fe46ee
cleanup README point
patrick-ogrady Aug 27, 2023
dd01be6
update mocks
patrick-ogrady Aug 27, 2023
98f072d
add poc
patrick-ogrady Aug 27, 2023
1fde94f
add span for waitRoot
patrick-ogrady Aug 27, 2023
6c5cf69
fix VerifySignatures
patrick-ogrady Aug 27, 2023
ba39b5d
make signature verification a config
patrick-ogrady Aug 27, 2023
6be6c04
add a TODO for splitting parallelism
patrick-ogrady Aug 27, 2023
e7b37a6
update to tip of dev
patrick-ogrady Aug 28, 2023
99022d3
split parallelism
patrick-ogrady Aug 28, 2023
b8e62f5
set cores 50/50
patrick-ogrady Aug 28, 2023
b3a0a99
wait root calc metric
patrick-ogrady Aug 28, 2023
0636c17
add more TODOs
patrick-ogrady Aug 28, 2023
ef6c44d
update logic to handle unprocessed block post-state sync
patrick-ogrady Aug 28, 2023
89cf991
more progress
patrick-ogrady Aug 28, 2023
684d736
add more notes
patrick-ogrady Aug 28, 2023
f3eb026
use nil in vm
patrick-ogrady Aug 28, 2023
64a2601
finish comments on View
patrick-ogrady Aug 28, 2023
8bfa8a0
nits
patrick-ogrady Aug 28, 2023
bf2f378
comment nit
patrick-ogrady Aug 28, 2023
61bf66d
comment nits
patrick-ogrady Aug 28, 2023
4f77c6f
fix genesis handling
patrick-ogrady Aug 28, 2023
395a296
change variable name
patrick-ogrady Aug 28, 2023
ea58c3e
use math.Max
patrick-ogrady Aug 28, 2023
e995d5a
add more logging
patrick-ogrady Aug 28, 2023
51e63d8
more cleanup
patrick-ogrady Aug 28, 2023
fa73457
add TODO for invariant change
patrick-ogrady Aug 28, 2023
689d3bf
[chain] Remove Parent Block Dependency during Verify (#427)
patrick-ogrady Aug 31, 2023
0203327
populate more of README
patrick-ogrady Aug 31, 2023
7d6a81f
commit WIP
patrick-ogrady Aug 31, 2023
b4a935e
progress
patrick-ogrady Sep 1, 2023
1fe04cc
final pass on README
patrick-ogrady Sep 1, 2023
d50d88e
Merge branch 'main' into defer-root-v3
patrick-ogrady Sep 1, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
set cores 50/50
  • Loading branch information
patrick-ogrady committed Aug 28, 2023
commit b8e62f58de8d5729c94c62aa9ebe4b94184e21e5
7 changes: 4 additions & 3 deletions vm/dependencies.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ type Handlers map[string]*common.HTTPHandler
type Config interface {
GetTraceConfig() *trace.Config
// Parallelism is split between signature verification
// and root generation.
// and root generation (50/50), where any odd cores
// are added to signature verification.
//
// These are typically both done at the same time and will
// cause CPU thrashing if both given full access to a
// These operations are typically both done at the same time
// and will cause CPU thrashing if both given full access to a
// node's CPU.
GetParallelism() int
GetMempoolSize() int
Expand Down
4 changes: 2 additions & 2 deletions vm/vm.go
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ func (vm *VM) Initialize(
//
// If [parallelism] is odd, we assign the extra
// core to signature verification.
sigParallelism := parallelism/2 + parallelism%2
if sigParallelism == 0 {
sigParallelism := parallelism - rootGenParallelism
patrick-ogrady marked this conversation as resolved.
Show resolved Hide resolved
if sigParallelism <= 0 {
sigParallelism = 1
}
vm.sigWorkers = workers.NewParallel(sigParallelism, 100) // TODO: make job backlog a const
Expand Down