Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github workflow to identify stale issues and PRs #279

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

najeal
Copy link
Contributor

@najeal najeal commented Jul 25, 2023

Close #261

I used the PR identified in the issue to create this PR.
This puts label lifecycle/stale on issues after 30 days of inactivity and on PRs after 60 days of inactivity.

I just deleted useless values close-issue-label: lifecycle/rotten and close-pr-label: lifecycle/rotten because the workflow does not auto-close issues/PRs.

@najeal najeal requested a review from patrick-ogrady as a code owner July 25, 2023 21:22
name: Mark stale issues and pull requests
on:
schedule:
- cron: '0 0 * * 0' # Run every day at midnight UTC on Sunday
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't make sense? Does it run every day or just on Sunday's?

(I'd prefer every day at midnight)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means any day (1-31) of any month (January to December) but it needs to be the Sunday.
I will switch to 0 0 * * * to run every day at midnight 👍


# Issue configuration
days-before-issue-stale: 60
stale-issue-message: 'This issue has become stale because it has been open 60 days with no activity. Adding the `lifecycle/frozen` label will cause this issue to ignore lifecycle events.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "will exempt this issue from future lifecycle events."


# PR configuration
days-before-pr-stale: 30
stale-pr-message: 'This PR has become stale because it has been open for 30 days with no activity. Adding the `lifecycle/frozen` label will cause this PR to ignore lifecycle events.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same nit with this wording

@najeal
Copy link
Contributor Author

najeal commented Jul 25, 2023

@patrick-ogrady by the way I did not sign my first commit. As soon as you approve I will sign it.

Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@patrick-ogrady patrick-ogrady merged commit d2adf52 into ava-labs:main Jul 25, 2023
@patrick-ogrady
Copy link
Contributor

@patrick-ogrady by the way I did not sign my first commit. As soon as you approve I will sign it.

I overrode this protection for this PR because your last commit was signed (all that shows on main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add action to identify stale issues/PRs
2 participants