Improve TState
#1834
Open
Improve TState
#1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
internal/fetcher/fetcher_test.go
Outdated
| @@ -142,12 +150,16 @@ func TestFetchSameKeysSlow(t *testing.T) { | |||
| stateKeys.Add(keyBase+strconv.Itoa(k), state.Read) | |||
| } | |||
| txID := ids.GenerateTestID() | |||
| keys := make([]string, 0, len(stateKeys)) | |||
There was a problem hiding this comment.
converting the state keys map into a keys slice seems to be a common usage pattern; do you think it would make sense to create a function that would encapsulate that ?
There was a problem hiding this comment.
For the tests, we can switch to generating database keys instead of generating state keys + immediately stripping their permissions. But agree that we should add a function that converts state keys into a keys slice.
RodrigoVillar
requested review from
aaronbuchwald and
joshua-kim
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following improvements related to
TState:fetchernow takes just the database keys that it needs to fetch, rather than state keys (i.e. database keys + it's permissions) asfetcheris not and should not be responsible for permission validationTStatehave been replaced by aScopeinterface which implements both reads and permission validation requests (i.e.Has()).TStateRecorderhas been replaced bySimulatedScopedbtesthas been moved into its own package, following the convention in AvalancheGo.