nit

Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>

x/dsmr/node.go

@@ -42,7 +42,6 @@ var (
 	ErrInvalidBlockHeight                  = errors.New("invalid block height")
 	ErrInvalidBlockTimestamp               = errors.New("invalid block timestamp")
 	ErrInvalidWarpSignature                = errors.New("invalid warp signature")
-	ErrDuplicateChunkCert                  = errors.New("duplicate chunk cert")
 )
 
 type Validator struct {
@@ -281,15 +280,6 @@ func (n *Node[T]) Verify(ctx context.Context, parent Block, block Block) error {
 	}
 
 	for _, chunkCert := range block.ChunkCerts {
-		_, ok, err := n.storage.GetChunkBytes(chunkCert.Expiry, chunkCert.ChunkID)
-		if err != nil && !errors.Is(err, database.ErrNotFound) {
-			return fmt.Errorf("failed to get chunk: %w", err)
-		}
-
-		if ok {
-			return fmt.Errorf("%w: %s", ErrDuplicateChunkCert, chunkCert.ChunkID)
-		}
-
 		if err := chunkCert.Verify(
 			ctx,
 			n.networkID,

x/dsmr/node_test.go

@@ -1188,18 +1188,6 @@ func Test_Verify_BadBlock(t *testing.T) {
 			},
 			wantErr: ErrInvalidBlockTimestamp,
 		},
-		{
-			name: "duplicate chunk cert",
-			blk: func(_ ChunkCertificate, parent Block) Block {
-				return Block{
-					ParentID:   parent.GetID(),
-					Height:     parent.Height + 1,
-					Timestamp:  parent.Timestamp + 1,
-					ChunkCerts: parent.ChunkCerts,
-				}
-			},
-			wantErr: ErrDuplicateChunkCert,
-		},
 		{
 			name: "nil chunk certs",
 			blk: func(_ ChunkCertificate, parent Block) Block {

x/dsmr/storage.go

@@ -233,7 +233,7 @@ func (s *ChunkStorage[T]) GatherChunkCerts() []*ChunkCertificate {
 
 	chunkCerts := make([]*ChunkCertificate, 0, len(s.chunkMap))
 	for _, chunk := range s.chunkMap {
-		if chunk.Cert == nil {
+		if chunk.Cert == nil || chunk.Available {
 			continue
 		}
 		chunkCerts = append(chunkCerts, chunk.Cert)