Generalize builder #1767
Merged
Generalize builder #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
requested review from
aaronbuchwald and
joshua-kim
as code owners
Co-authored-by: Aaron Buchwald <aaron.buchwald56@gmail.com>
internal/builder/time.go
Outdated
| Len(context.Context) int // items | ||
| } | ||
|
|
||
| type GetPreferedTimestampAndBlockGap func(int64) (int64, int64) |
There was a problem hiding this comment.
nit: could we add variable names and a comment to make this more easily readable and an error, so that we don't need to use a special case of the latter return value?
aaronbuchwald
approved these changes
Nov 14, 2024
| @@ -324,6 +323,14 @@ func (vm *VM) Initialize( | |||
|
|
|||
| vm.mempool = mempool.New[*chain.Transaction](vm.tracer, vm.config.MempoolSize, vm.config.MempoolSponsorSize) | |||
|
|
|||
| vm.builder = builder.NewTime(toEngine, snowCtx.Log, vm.mempool, func(t int64) (int64, int64, error) { | |||
There was a problem hiding this comment.
Hmm moving this below where we apply options means that we will set the builder to this value even if the option to override the builder is specified. Moving this back above options causes the integration tests (which use the manual builder) to fail.
Seems this change may have introduced a bug in the manual builder that is covered up by this change. We could use builder.NewTime rather than manual implementation (clearly we don't need the manual implementation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ?
Decouple components that are unnecessarily tied to the chain package because they depend on either the block or transaction types. We should remove the pattern of using a resolutions.go and dependencies.go file to pass around mega objects and switch to passing in the required parameters to each type we need to construct.
This PR focuses on decoupling the builder from the chain package.