Convert e2e tmpnet #1249
Merged
Convert e2e tmpnet #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
aaronbuchwald
commented
Aug 5, 2024
|
Depends on ava-labs/avalanchego#3290 to make sure tmpnet passes the subnet config correctly |
joshua-kim
reviewed
Aug 13, 2024
| factory = auth.NewED25519Factory(priv) | ||
|
|
||
| gen := genesis.Default() | ||
| gen.WindowTargetUnits = fees.Dimensions{18446744073709551615, 18446744073709551615, 18446744073709551615, 18446744073709551615, 18446744073709551615} |
There was a problem hiding this comment.
What are these numbers based off of? They seem weirdly precise
There was a problem hiding this comment.
Good call out, added a comment here and for MaxBlockUnits
| Nodes: nodes, | ||
| DefaultFlags: tmpnet.FlagsMap{ | ||
| config.ProposerVMUseCurrentHeightKey: true, | ||
| config.InboundThrottlerVdrAllocSizeKey: 10737418240, |
There was a problem hiding this comment.
Also wondering where these defaults come from
There was a problem hiding this comment.
These come from the existing code. Some of them are arbitrary or determined by iterating to the necessary parameters to make sure AvalancheGo does not overthrottle.
joshua-kim
reviewed
Aug 13, 2024
| gen.MaxBlockUnits = fees.Dimensions{1800000, 18446744073709551615, 18446744073709551615, 18446744073709551615, 18446744073709551615} | ||
| // Set WindowTargetUnits to MaxUint64 for all dimensions to iterate full mempool during block building. | ||
| gen.WindowTargetUnits = fees.Dimensions{math.MaxUint64, math.MaxUint64, math.MaxUint64, math.MaxUint64, math.MaxUint64} | ||
| // Set all lmiits to MaxUint64 to avoid limiting block size for all dimensions except bandwidth. Must limit bandwidth to avoid building |
joshua-kim
approved these changes
Aug 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from using avalanche-network-runner to tmpnet for the existing e2e tests and run script to start a local network w/ MorpheusVM.
This enables starting a network running tmpnet w/ the existing run script:
Devs can also enter the tmpnet directory printed out to view the configuration of the tmpnet and explore the logs produced by the nodes:
Outputs:
will output the logs produced by the given nodeID from the C-Chain.
Devs can stop the tmpnet network using the existing stop script:
To run the test suite from the MorpheusVM directory, developers can execute the run script with the environment variable
MODE=test:Additionally, the script now passes in any additional arguments to test execution, so that you can pass in standard ginkgo filtering arguments.
For example, to execute only the
GetNetworke2e test: