Skip to content

Missing p2ptest functions after AvalancheGo dependency update #1951

@Elvis339

Description

@Elvis339

Missing p2ptest functions after AvalancheGo dependency update

Description

After updating the AvalancheGo dependency to use the p2p sampler functionality in PR #1911, several functions from p2ptest package that our codebase relies on have been removed. This is currently blocking our implementation progress.

Affected PR

Some example of missing p2ptest functions

We need the following p2ptest functions that were previously available:

From

p2ptest.NewSelfClient(
:

  • Network creation and management functions
  • Node connection utilities
  • Test network configuration

From

client: p2ptest.NewClientWithPeers(t, ctx, clientNodeID, p2p.NoOpHandler{}, handlers),
:

  • Client test utilities
  • Network simulation helpers

Required AvalancheGo PRs

For our implementation to proceed, we need the following AvalancheGo PRs to be merged:

  1. [avalanchego#3394](Implement ACP-118 Aggregator avalanchego#3394) - ACP-118 signature aggregator
  2. [avalanchego#3709](Add canoto serialization support to the block context avalanchego#3709) - canoto.Field support for the block context

Impact

Possible Solutions

  1. Restore the removed p2ptest functions in AvalancheGo
  2. Create alternative implementations of these functions in our codebase
  3. Refactor our code to avoid dependency on these specific functions
  4. Coordinate with AvalancheGo maintainers to understand if these functions were intentionally removed and what the recommended alternative is

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency file

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions