Skip to content

Conversation

@demosdemon
Copy link
Contributor

I noticed there was one remaining component using arc-swap. This change replaces it with a standard Mutex. And, removes the dependency on arc-swap.

I noticed there was one remaining component using arc-swap. This change
replaces it with a standard Mutex. And, removes the dependency on
arc-swap.
@demosdemon demosdemon marked this pull request as ready for review November 17, 2025 19:46
@demosdemon demosdemon requested a review from rkuris as a code owner November 17, 2025 19:46
@demosdemon demosdemon requested a review from AminR443 November 17, 2025 19:46
@AminR443
Copy link
Contributor

Sounds great. I planned on doing this sometime soon, was not sure about performance implications though; Are we sure that mutex is the best option here too?

@demosdemon
Copy link
Contributor Author

Are we sure that mutex is the best option here too?

The parent here has nearly the same usages as MaybePersisted; it is only accessed during commit -- to verify the parent is committed and has the expected hash (parent_hash_is) or to indicate the parent is committed and set its hash (commit_reparent). There should be no contention on the lock right now since there's no parallelism on commits.

@demosdemon demosdemon merged commit b8f30ee into main Nov 17, 2025
47 checks passed
@demosdemon demosdemon deleted the brandon.leblanc/remove-arc-swap branch November 17, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants