-
Notifications
You must be signed in to change notification settings - Fork 24
feat(ffi-refactor): replace sequence id with pointer to proposals (8/8) #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics Change Detection
|
rkuris
reviewed
Aug 22, 2025
alarso16
reviewed
Aug 22, 2025
Contributor
Author
|
I'm gonna move this back to draft and get the coreth change ready first. |
This is the final PR in the series to refactor the FFI layer to be more rust and also a bit more Gooey. This replaces the serial atomic id for proposals with a pointer to the actual structures. The wrapper that includes the db handle is only necessary in order to do the cached view shenanigans. I will come back to that later.
Member
|
Closes #1272 |
…blanc/serialized-range-proofs
…eblanc/ffi-refactor
Contributor
Author
|
My coreth PR will be merged soon. This is r4r again. |
…lized-range-proofs
…eft-exclusion-proof
We were incorrectly checking the length of the last node's full path against the length of the key being proven. This meant that if the last node's full path was the same _length_ as the key being proven, but the key was different, we would incorrectly verify the proof by expecting a value when there should be none.
…leblanc/fix-verify-exclusion-proof
…leblanc/fix-verify-exclusion-proof
…leblanc/fix-verify-exclusion-proof
…eblanc/ffi-refactor
…sion-proof' into brandon.leblanc/ffi-refactor
Base automatically changed from
brandon.leblanc/serialized-range-proofs
to
main
September 16, 2025 19:16
rkuris
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final PR in the series to refactor the FFI layer to be more rust and also a bit more Gooey.
This replaces the serial atomic id for proposals with a pointer to the actual structures. The wrapper that includes the db handle is only necessary in order to do the cached view shenanigans. I will come back to that later.
Depends On: #1228