move block extender to vm

[ceyonur]

Why this should be merged

This PR moves atomic block extension and relevant code to atomic pkg

Note: some "extra" changes are introduced with TODOs. These are to prevent UTs being failed an will be cleaned up with upcoming PRs.

How this works

This pull request introduces significant refactoring and feature updates to the EVM plugin, primarily focusing on modularizing the atomic VM functionality, improving error handling, and enhancing code organization. The changes include renaming and restructuring files, updating error handling, and introducing a new VM wrapper for atomic extensions.

Refactoring and Modularization:

• File restructuring: Renamed several files under plugin/evm/atomic to plugin/evm/atomic/vm for better modularity and organization. For example, atomic_block_extension.go was renamed to block_extension.go and tx_semantic_verifier.go was moved to the vm subdirectory. [1] [2] [3]

• New VM wrapper: Introduced a new VM struct in plugin/evm/atomic/vm/vm.go to encapsulate the atomic extension logic, providing a cleaner and more extensible interface. This includes the WrapVM function and the Initialize method for setting up the VM and its extensions.

Code Enhancements:

• Error handling improvements: Updated error variables to be exported (ErrMissingUTXOs, ErrEmptyBlock) for better consistency and usage across the codebase. [1] [2] [3]

• Refactored method calls: Replaced direct calls to atomicBackend and mempool with corresponding methods (AtomicBackend(), AtomicMempool()) for improved encapsulation and abstraction. [1] [2] [3] [4]

Dependency Updates:

• Atomic package usage: Updated references in tx_semantic_verifier.go and related files to use the atomic package explicitly, improving clarity and dependency management. For example, atomic.CalculateDynamicFee and atomic.Codec.Unmarshal are now used. [1] [2]

• Test updates: Adjusted test files (export_tx_test.go, import_tx_test.go) to reflect the new atomicvm package structure and updated imports accordingly. [1] [2]

Additional Changes:

• Extension configuration: Added validation for the Config struct in plugin/evm/extension/config.go and introduced a new SetExtensionConfig method in the ExtensibleVM interface for better configuration management. [1] [2]

These changes collectively enhance the maintainability, readability, and modularity of the EVM plugin codebase.

How this was tested

Existing tests

Note:

Need to be documented?

No

Need to update RELEASES.md?

No

[ARR4N]

Please resolve the merge conflicts so we're not reviewing out-of-date code.

This PR is also unfocussed, hence being a 3500-line delta. Why does file restructuring need to be done at the same time as dependency updates, creating a new VM wrapper, etc.? It makes it extremely difficult to review as we have to understand so many interlocking parts at the same time.

[ceyonur]

Please resolve the merge conflicts so we're not reviewing out-of-date code.

This PR is also unfocussed, hence being a 3500-line delta. Why does file restructuring need to be done at the same time as dependency updates, creating a new VM wrapper, etc.? It makes it extremely difficult to review as we have to understand so many interlocking parts at the same time.

This is because the previous PR was squashed, doing a rebase now

[alarso16]

fwict looks good, but the recursive initialization doesn't seem super great

[ARR4N]

I spoke with @StephenButtolph about wrapper VMs and all of the problems arise when there's a non 1:1 mapping between wrapping and inner blocks (e.g. multiple proposervm outer blocks could reference the same inner block). I don't see this arising in this refactor, but noting so we all keep it in mind.