chore(all): final small changes to the libevm branch #862

qdm12 · 2025-03-07T11:18:50Z

Why this should be merged

Final changes that will be squashed into the libevm branch, suggested from the PR review of #820

This also notably contains:

suggested changes from the feedback on Merge master branch into libevm branch #828
add test to check PredicateBytesFromExtra is the inverse of SetPredicateBytesInExtra
Cherry pick 2773bbb

Let me know if you want me to split this PR, that's no problem as well.

How this works

Each line changed has a corresponding resolved conversation on chore(all): libevm phase 2.5 #820 which you can check by finding the same file/line number in the files changed
Commits with revert means the code is reverted to how it is on the master branch because the change is actually not needed.

You can compare this branch to master here as well, for example to check on reversion changes.

How this was tested

Need to be documented?

Need to update RELEASES.md?

consensus/dummy/consensus.go

alarso16

lgtm

accounts/abi/bind/util_test.go

core/blockchain.go

triedb/pathdb/metrics.go

plugin/evm/rawdb/accessors_state_sync_test.go

… for clarity

…izeAndAssemble Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Quentin McGaw <quentin.mcgaw@gmail.com>

…edCornerCases

…eaderGasFields

…gine.Finalize

…Header

…n testBlockChain.CurrentBlock

… LegacyPool.startPeriodicFeeUpdate

…te test field in TestPredicateBytesExtra

…StateDB

This reverts commit c6072ff.

…multicoin balance Signed-off-by: Quentin McGaw <quentin.mcgaw@gmail.com>

…icoin balance

qdm12 · 2025-03-28T07:03:49Z

No-op force push due to a missing signature 🤷

Changes applied from comments on the review of ava-labs/coreth#820 See original PR ava-labs/coreth#862 Signed-off-by: Quentin McGaw <quentin.mcgaw@gmail.com> Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>

ARR4N · 2025-03-28T09:45:18Z

No-op force push due to a missing signature 🤷

Even "no-op" force pushes can break other people's workflows. Just GPG-sign everything.

By definition there can never be a completely no-op force push. While it may not change the file tree, it will change the commit history, and that's what GitHub relies on. If it was a no-op then a force push would be unnecessary.

Changes applied from comments on the review of ava-labs/coreth#820 See original PR ava-labs/coreth#862 Signed-off-by: Quentin McGaw <quentin.mcgaw@gmail.com> Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>

qdm12 mentioned this pull request Mar 7, 2025

chore(all): libevm phase 2.5 #820

Merged

1 task

qdm12 changed the title ~~chore(all): final changes to the libevm branch~~ chore(all): final small changes to the libevm branch Mar 7, 2025

ARR4N reviewed Mar 10, 2025

View reviewed changes

consensus/dummy/consensus.go Outdated Show resolved Hide resolved

alarso16 approved these changes Mar 10, 2025

View reviewed changes

darioush approved these changes Mar 10, 2025

View reviewed changes

qdm12 added the Do not merge label Mar 11, 2025

qdm12 mentioned this pull request Mar 11, 2025

chore(accounts/abi/bind): revert accidental changes to TestGetSenderNativeAssetCall #866

Merged

qdm12 force-pushed the qdm12/libevm-last-changes branch from 806247a to 78d91ea Compare March 11, 2025 09:55

ARR4N reviewed Mar 11, 2025

View reviewed changes

accounts/abi/bind/util_test.go Outdated Show resolved Hide resolved

ARR4N requested changes Mar 11, 2025

View reviewed changes

accounts/abi/bind/util_test.go Outdated Show resolved Hide resolved

ARR4N force-pushed the libevm branch from 0323c39 to 8d305cd Compare March 11, 2025 15:58

qdm12 force-pushed the qdm12/libevm-last-changes branch 2 times, most recently from 48c2b2e to 7d06d0e Compare March 17, 2025 17:40

qdm12 mentioned this pull request Mar 19, 2025

update libevm branch with coreth's libevm branch commits ava-labs/subnet-evm#1502

Merged

darioush reviewed Mar 19, 2025

View reviewed changes

core/blockchain.go Show resolved Hide resolved

qdm12 commented Mar 19, 2025

View reviewed changes

triedb/pathdb/metrics.go Show resolved Hide resolved

darioush reviewed Mar 19, 2025

View reviewed changes

plugin/evm/rawdb/accessors_state_sync_test.go Outdated Show resolved Hide resolved

qdm12 force-pushed the qdm12/libevm-last-changes branch 2 times, most recently from b9073f0 to 2c501ed Compare March 24, 2025 14:57

qdm12 and others added 11 commits March 24, 2025 15:59

chore(plugin/evm/header): SetPredicateBytesInExtra uses an else block…

ea9895f

… for clarity

chore(consensus/dummy): use already existing variable headerExtra

729d9a2

chore(consensus/dummy/consensus.go): simplify big int assign in Final…

3d316ed

…izeAndAssemble Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Quentin McGaw <quentin.mcgaw@gmail.com>

chore(accounts/abi/bind): fix comment for TestGetSenderNativeAssetCall

a20ef87

accounts/abi/bind/utils_test.go: revert error check in TestWaitDeploy…

c250b3c

…edCornerCases

consensus/dummy/consensus.go: rename configExtra to config in verifyH…

aaf9a47

…eaderGasFields

consensus/dummy/consensus.go: rename configExtra to config in DummyEn…

81b6aa3

…gine.Finalize

core/blockchain.go: revert comment on CacheConfig.triedbConfig

4dfcdaf

core/chain_makers.go: rename configExtra to config in chainMaker.make…

993c38e

…Header

core/txpool/blobpool/blobpool_test.go: rename configExtra to config i…

b67c9c0

…n testBlockChain.CurrentBlock

core/txpool/legacypool/legacypool.go: assign ap3Timestamp variable in…

1587d63

… LegacyPool.startPeriodicFeeUpdate

qdm12 added 20 commits March 28, 2025 07:56

core/exstate/statedb.go: unexport internal StateDB vmStateDB field

0d6a6a3

plugin/evm/header/extra_test.go: deep copy wantPredicate from predica…

eac14dc

…te test field in TestPredicateBytesExtra

Merge branch 'libevm' into qdm12/libevm-last-changes

1804c92

params/extras: use upstream NewTimestampCompatError

cf8b6cb

params/extras: use upstream ConfigCompatError

fc8fcc7

params/hooks_libevm.go: clarify TODO comment foro accessibleState.Get…

5c7e279

…StateDB

sload.json: remove berlinBlock key

5c21e8b

Merge branch 'libevm' into qdm12/libevm-last-changes

c0accdf

Revert "sload.json: remove berlinBlock key"

a9ec9ad

This reverts commit c6072ff.

params/extras: use alias ethparams to import libevm/params

91e152a

revert: core/blockchain.go: re-add previousRoot != root check

ebb2492

accounts/abi/bind/util_test.go: revert reversion of error check

b09d1a9

core/state/database.go: actual functions that propagate values

8e252d2

plugin/evm/customrawdb: remove ethrawdb alias and use simply rawdb

bf869bb

plugin/evm: add vm.rulesExtra helper function

1f3ca87

plugin/evm/header/block_gas_cost.go: revert headerExtra -> extra

28055c6

core/state/statedb_multicoin_test.go: clearer assertion for expected …

f7edced

…multicoin balance Signed-off-by: Quentin McGaw <quentin.mcgaw@gmail.com>

plugin/evm/header/extra_test.go: re-add previous tests

2f5be5c

core/state/statedb_multicoin_test.go: clearer assertion for zero mult…

8a75d6c

…icoin balance

plugin/evm: rename rulesExtra -> rules

8b5354b

qdm12 force-pushed the qdm12/libevm-last-changes branch from 1c6b47f to 8b5354b Compare March 28, 2025 07:03

Merge branch 'libevm' into qdm12/libevm-last-changes

4b092e7

qdm12 merged commit 8f7795f into libevm Mar 28, 2025
6 checks passed

qdm12 deleted the qdm12/libevm-last-changes branch March 28, 2025 07:19

qdm12 mentioned this pull request Apr 8, 2025

fix(metrics/prometheus): skip metric types GaugeInfo #910

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(all): final small changes to the libevm branch #862

chore(all): final small changes to the libevm branch #862

Uh oh!

qdm12 commented Mar 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

alarso16 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qdm12 commented Mar 28, 2025

Uh oh!

Uh oh!

ARR4N commented Mar 28, 2025

Uh oh!

Uh oh!

chore(all): final small changes to the libevm branch #862

chore(all): final small changes to the libevm branch #862

Uh oh!

Conversation

qdm12 commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why this should be merged

How this works

How this was tested

Need to be documented?

Need to update RELEASES.md?

Uh oh!

Uh oh!

alarso16 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qdm12 commented Mar 28, 2025

Uh oh!

Uh oh!

ARR4N commented Mar 28, 2025

Uh oh!

Uh oh!

qdm12 commented Mar 7, 2025 •

edited

Loading