This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Update wrap.Verify interface changes #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
requested review from
a team,
ceyonur and
darioush
as code owners
tsachiherman
changed the title
aaronbuchwald
previously approved these changes
Jan 28, 2025
Collaborator
aaronbuchwald
left a comment
aaronbuchwald
left a comment
There was a problem hiding this comment.
This LGTM - I think it's preferred that we align the signature tests with AvalancheGo upstream as well ie. use canonicalErr instead of getValidatorSetErr
darioush
previously approved these changes
Jan 28, 2025
darioush
left a comment
darioush
left a comment
There was a problem hiding this comment.
lgtm, please only merge after avalanchego pr has merged
Contributor
Author
|
Yes, of course
…On Tue, Jan 28, 2025, 4:18 PM Darioush Jalali ***@***.***> wrote:
***@***.**** approved this pull request.
lgtm, please only merge after avalanchego pr has merged
—
Reply to this email directly, view it on GitHub
<#769 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2OOH2VO7WC6SGESAK65J32M7XZZAVCNFSM6AAAAABWBARJUOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNZZGQZTGNRSGE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
tsachiherman
dismissed
aaronbuchwald’s stale review
The merge-base changed after approval.
darioush
approved these changes
Jan 29, 2025
ceyonur
approved these changes
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Updated interface changes per ava-labs/avalanchego#3679
How this works
Intuitive.
How this was tested
Existing tests.
Need to be documented?
No
Need to update RELEASES.md?
No