update comments and file names #1204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
force-pushed
the
alarso16/firewood-clarifications
branch
from
7f42cd2 to
5e0fbdc
Compare
ceyonur
reviewed
Sep 16, 2025
ceyonur
reviewed
Sep 16, 2025
RodrigoVillar
approved these changes
Sep 23, 2025
Contributor
RodrigoVillar
left a comment
RodrigoVillar
left a comment
There was a problem hiding this comment.
One minor nit - otherwise LGTM.
ceyonur
reviewed
Sep 23, 2025
ceyonur
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As pointed out in several PRs, some of the documentation around the Firewood triedb implementation is lacking. This addresses this, as well as a few other cleanups.
See ava-labs/subnet-evm#1704 (will close after copied into subnet-evm)
How this works
Adds comments, refactors a path check, renames file.
Note the file name change will be breaking for anyone currently running a Firewood node on restart
How this was tested
UT
Need to be documented?
No
Need to update RELEASES.md?
No