style: revive fix based on feedback #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
force-pushed
the
alarso16/revive-edits
branch
from
8281836 to
3233835
Compare
alarso16
changed the title
JonathanOppenheimer
approved these changes
Sep 4, 2025
ARR4N
requested changes
Sep 5, 2025
fix: add explanation for nolint Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: Austin Larson <78000745+alarso16@users.noreply.github.com>
alarso16
force-pushed
the
alarso16/revive-edits
branch
from
f2497bb to
3893e0e
Compare
ARR4N
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Based on ava-labs/subnet-evm#1704, there were a few more style decisions I made that were incorrect, as well as accidentally deleting an internal API...
How this works
Restores some changes with nolint, removes some
_How this was tested
Lint
Need to be documented?
No
Need to update RELEASES.md?
No