Skip to content

style: enable nilerr linter #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 4, 2025
Merged

style: enable nilerr linter #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
302e603
enable nilerr
JonathanOppenheimer Sep 3, 2025
3d117e0
silence linter
JonathanOppenheimer Sep 3, 2025
63ea66b
Update sync/statesync/trie_sync_tasks.go
JonathanOppenheimer Sep 4, 2025
fd897f6
fix suggestion commit
JonathanOppenheimer Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .avalanche-golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ linters:
- ineffassign
- misspell
- nakedret
# - nilerr
- nilerr
- noctx
- nolintlint
- perfsprint
Expand Down
2 changes: 1 addition & 1 deletion sync/statesync/trie_sync_tasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (s *storageTrieTask) OnStart() (bool, error) {
}
storageTrie, err := trie.New(trie.StorageTrieID(s.sync.root, s.root, firstAccount), s.sync.trieDB)
if err != nil {
return false, nil
return false, nil //nolint:nilerr // the storage trie does not exist, so it should be rerequested
}

// If the storage trie is already on disk, we only need to populate the storage snapshot for [accountHash]
Expand Down
Loading