Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR fully wraps the plugin/evm/vm as innerVM in atomic/vm/vm and completely seperates out atomicVM from plugin/evm/vm.
This PR does not move tests to atomic package, a subsequent PR will do that with introducing a refactor to vm tests.
How this works
This pull request introduces several updates to the
plugin/evm/atomic/vm
module, focusing on improving code consistency, simplifying the verification logic, and updating dependencies. The most significant changes include replacingctx
withCtx
for better naming consistency, refactoring theSemanticVerifier
implementation, and updating theavalanchego
dependency version.Code consistency improvements:
ctx
withCtx
across theVM
struct and its associated methods to align with Go conventions for exported fields. This change affects multiple files, includingplugin/evm/atomic/vm/vm.go
andplugin/evm/atomic/vm/api.go
. [1] [2] [3] [4] [5]Refactoring for semantic verification:
SemanticVerifier
into a newVerifierBackend
andsemanticVerifier
structure, simplifying the logic for verifying atomic transactions. This change improves modularity and readability inplugin/evm/atomic/vm/tx_semantic_verifier.go
. [1] [2] [3] [4] [5]Dependency updates:
avalanchego
dependency ingo.mod
to versionv1.13.1-rc.4.0.20250531182522-ce450499b7d7
for compatibility with the latest changes.github.com/NYTimes/gziphandler v1.1.1
as an indirect dependency ingo.mod
.Workflow adjustments:
run-monitored-tmpnet-cmd
action version in.github/workflows/ci.yml
toce450499b7d7c3f7b8927185b6a7b778856a702e
for both standard and Warp E2E tests. [1] [2]Miscellaneous improvements:
SetState
andCreateHandlers
inplugin/evm/atomic/vm/vm.go
, ensuring the atomic VM fully wraps the inner VM. [1] [2]How this was tested
Modified existing tests
Need to be documented?
no
Need to update RELEASES.md?
updated