Skip to content

Conversation

@ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Jun 16, 2025

Why this should be merged

There were few reviews in #1009 after it was merged. This PR intends to responde those.

How this works

This pull request refactors the atomic sync components in the EVM plugin to improve clarity and maintainability. Key changes include renaming internal types to exported ones, enhancing comments for better documentation, and updating initialization logic to align with the new architecture.

Refactoring of sync components:

  • plugin/evm/atomic/sync/extender.go: Renamed extender to Extender and updated comments to clarify its role as the sync extender for the atomic VM. Updated methods to align with the new exported type. [1] [2] [3]

  • plugin/evm/atomic/sync/summary_provider.go: Renamed summaryProvider to SummaryProvider and updated comments to describe its role in providing state summaries for the atomic trie. Adjusted initialization logic to match the new exported type.

Updates to VM initialization logic:

  • plugin/evm/atomic/vm/vm.go: Updated initialization of sync.Extender and sync.SummaryProvider to use exported types. Adjusted initialization of dependent components (atomicBackend, atomicTrie, and leafHandler) to improve clarity and consistency. [1] [2]

Minor corrections:

How this was tested

Existing tests

Need to be documented?

No

Need to update RELEASES.md?

No

@ceyonur ceyonur marked this pull request as ready for review June 16, 2025 13:12
@ceyonur ceyonur requested a review from a team as a code owner June 16, 2025 13:12
@ceyonur ceyonur added this pull request to the merge queue Jun 23, 2025
Merged via the queue into master with commit 2a813e3 Jun 23, 2025
9 checks passed
@ceyonur ceyonur deleted the atomic-vm-sync-reviews branch June 23, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants