Skip to content

Conversation

@sebaxor
Copy link
Contributor

@sebaxor sebaxor commented Aug 22, 2025

This PR consolidates a set of bugfixes and safe refactors to improve reliability and UX across the hackathons flow.

What’s fixed / changed
Commented out the Reward Board link in UserButton to avoid a broken/unused path. (commit 4890e71)
Strengthened hackathon validation and data handling to prevent inconsistent state during submission. (commit 5b7fda0)
Optimized progress calculation in GeneralSecure to avoid edge-case miscomputations. (commit efd1bc6)
Improved dialog handling and invitation logic for consistent open/close and error states. (commit f3a5e75)
Cleaned up the project submission context and simplified submission logic to reduce side effects. (commits 8f06564, 14c4f3c, ac2e5fd)
Additionally, multiple “bugfix-project-submission” PRs were merged into this branch, aligning fixes and avoiding regressions. (PRs #50, #51, #52, #53, #54)

Scope
No new features; changes are bugfixes and small refactors.
No breaking changes expected.
Risk is low; behavior changes are limited to guarding invalid states and removing an unsafe link.
Testing notes
Verified creation and edit flows for hackathon submissions (happy path + invalid inputs).
Checked dialog open/close sequences and invite flows.
Reference commits (Aug 17–21, 2025)
refactor: comment out Reward Board link in UserButton component — 4890e71. 0
refactor: enhance hackathon validation and data handling — 5b7fda0. 1
refactor: optimize progress calculation in GeneralSecure component — efd1bc6. 2
refactor: improve dialog handling and invitation logic — f3a5e75. 3
refactor: clean up code and improve project submission context — 8f06564. 4
refactor: simplify project submission logic and enhance data handling — 14c4f3c. 5
refactor: enhance form validation and data handling in submission form — ac2e5fd. 6
Merges: PRs #50, #51, #52, #53, #54 into this branch. 7

Riot-pls and others added 23 commits July 20, 2025 11:29
- Removed unnecessary console logs and improved code formatting for consistency.
- Enhanced the project submission context by adding new state properties and actions for better management of project-related dialogs.
- Updated the project creation logic to use atomic transactions for improved reliability.
- Refactored the submission form to streamline data handling and validation processes.
…submission

BUGFIX: Solve duplicate project submissions
- Removed the submission restriction check in the GeneralSecure component for a smoother user experience.
- Updated the project submission context to correctly access the project ID from the response data structure.
- Added useEffect for reactive validation in the submission form hook, improving user feedback during input.
- Improved the FormSchema by adding detailed validation messages for various fields.
- Implemented preprocessing for GitHub repository and demo link inputs to ensure valid formats and uniqueness.
- Updated the useEffect for reactive validation to ensure fields are validated as the user types.
- Added a refinement to require an explanation when the idea is pre-existing.
…submission

Voyager ship/bugfix project submission
- Updated the invitation generation logic to return detailed results, including success status and invitation links.
- Improved error handling in the invitation process to provide clearer feedback on failures.
- Enhanced the MembersComponent to display invitation results and links for manual sharing.
- Added toast notifications for better user experience during the invitation process.
…submission

refactor: enhance invitation process and improve error handling
- Enhanced the GeneralSecure component by removing unnecessary dispatch calls and cleaning up the loading state.
- Updated the InvalidInvitationDialog and JoinTeamDialog to include toast notifications for better user feedback during modal interactions.
- Refactored the ProjectMemberWarningDialog to handle modal closure with action tracking, ensuring users are redirected appropriately.
- Improved the Members component by centralizing modal close logic and resetting state variables upon closure.
- Adjusted the ProjectSubmissionContext to correctly set team names based on project data.
- Introduced a debounced progress state to improve performance and user experience.
- Extracted progress calculation logic into a separate function for better readability and maintainability.
- Updated the ProgressBar to utilize the debounced progress value, ensuring smoother updates during form interactions.
- Updated hackathon validation logic to improve readability and maintainability.
- Changed date fields in HackathonHeader type from Date to string for better compatibility with API responses.
- Improved error handling in create and update hackathon functions to ensure proper validation and timezone handling.
- Refactored getFilteredHackathons function to streamline filtering and pagination logic.
…submission

Voyager ship/bugfix project submission
- Commented out the Reward Board link in the UserButton component to streamline the user interface.
- Maintained the existing structure for potential future use.
…submission

refactor: comment out Reward Board link in UserButton component
@sebaxor sebaxor requested a review from a team as a code owner August 22, 2025 16:00
@vercel
Copy link

vercel bot commented Aug 22, 2025

@sebaxor is attempting to deploy a commit to the Ava Labs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
builder-hub Ready Ready Preview Comment Aug 22, 2025 4:14pm
l1-toolbox Ready Ready Preview Comment Aug 22, 2025 4:14pm

@Andyvargtz Andyvargtz merged commit 7c43216 into ava-labs:Staging-hackathons Aug 22, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants