Fix connected weight calculation

peers/app_request_network.go

@@ -7,6 +7,7 @@ package peers
 
 import (
 	"context"
+	"encoding/hex"
 	"os"
 	"sync"
 	"time"
@@ -230,30 +231,37 @@ func (n *appRequestNetwork) ConnectToCanonicalValidators(subnetID ids.ID) (*Conn
 	if err != nil {
 		return nil, err
 	}
+
 	// We make queries to node IDs, not unique validators as represented by a BLS pubkey, so we need this map to track
 	// responses from nodes and populate the signatureMap with the corresponding validator signature
 	// This maps node IDs to the index in the canonical validator set
 	nodeValidatorIndexMap := make(map[ids.NodeID]int)
+	nodeIDs := set.NewSet[ids.NodeID](len(nodeValidatorIndexMap))
 	for i, vdr := range validatorSet {
 		for _, node := range vdr.NodeIDs {
 			nodeValidatorIndexMap[node] = i
+			nodeIDs.Add(node)
 		}
 	}
 
 	// Manually connect to all peers in the validator set
 	// If new peers are connected, AppRequests may fail while the handshake is in progress.
 	// In that case, AppRequests to those nodes will be retried in the next iteration of the retry loop.
-	nodeIDs := set.NewSet[ids.NodeID](len(nodeValidatorIndexMap))
-	for node := range nodeValidatorIndexMap {
-		nodeIDs.Add(node)
-	}
 	connectedNodes := n.ConnectPeers(nodeIDs)
 
-	// Check if we've connected to a stake threshold of nodes
+	// Calculate the total weight of connected validators.
+	connectedBLSPubKeys := set.NewSet[string](len(validatorSet))
 	connectedWeight := uint64(0)
 	for node := range connectedNodes {
-		connectedWeight += validatorSet[nodeValidatorIndexMap[node]].Weight
+		vdr := validatorSet[nodeValidatorIndexMap[node]]
+		blsPubKey := hex.EncodeToString(vdr.PublicKeyBytes)
+		if connectedBLSPubKeys.Contains(blsPubKey) {
+			continue
+		}
+		connectedWeight += vdr.Weight
+		connectedBLSPubKeys.Add(blsPubKey)
 	}
+
 	return &ConnectedCanonicalValidators{
 		ConnectedWeight:       connectedWeight,
 		TotalValidatorWeight:  totalValidatorWeight,