-
Notifications
You must be signed in to change notification settings - Fork 840
[ci] Support running re-execution benchmark with arbitrary version of Firewood #4650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Elvis339
wants to merge
22
commits into
master
Choose a base branch
from
es/enable-firewood-dev-workflow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d0155dd
ci(c-chain-reexecution-firewood)
Elvis339 e851903
lint
Elvis339 49b7fc3
Merge branch 'master' into es/enable-firewood-dev-workflow
Elvis339 2feeda4
Merge branch 'master' into es/enable-firewood-dev-workflow
Elvis339 6f21231
ci(firewood-benchmark): try go get first, fall back to Nix on failure
Elvis339 b3cc8ed
Merge branch 'es/enable-firewood-dev-workflow' of github.com:ava-labs…
Elvis339 e437658
refactor(build-firewood): move default config to script, simplify task
Elvis339 15b52ee
ci(firewood-benchmark): test workflow without the commit step
Elvis339 999c3f4
Merge branch 'master' into es/enable-firewood-dev-workflow
Elvis339 34a331f
Merge branch 'master' into es/enable-firewood-dev-workflow
Elvis339 cb5e59a
ci(c-chain-reexecution): add custom firewood/libevm support to reexec…
Elvis339 e0e784b
Merge branch 'es/enable-firewood-dev-workflow' of github.com:ava-labs…
Elvis339 cab333e
fix(c-chain-reexecution): add nix build env vars for self-hosted runners
Elvis339 c131420
lint(c-chain-reexecution): set 10 input params per gh workflow limit
Elvis339 f79c8d5
docs
Elvis339 c4561be
Merge branch 'master' into es/enable-firewood-dev-workflow
Elvis339 a89c44e
ci(c-chain-reexecution): skip benchmark comparison for custom firewoo…
Elvis339 d428155
ci(c-chain-reexecution): rename libevm and firewood inputs to libevm-…
Elvis339 87b3d4c
docs
Elvis339 6f5502b
Merge branch 'master' into es/enable-firewood-dev-workflow
Elvis339 6493598
ci(c-chain-reexecution): clarify firewood-ref skips benchmark comparison
Elvis339 0451870
Merge branch 'master' into es/enable-firewood-dev-workflow
Elvis339 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| POLYREPO_REVISION=6239973c9b | ||
| echo "Running polyrepo@${POLYREPO_REVISION} via go run..." | ||
| go run github.com/ava-labs/avalanchego/tests/fixture/polyrepo@"${POLYREPO_REVISION}" "${@}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the job definitions have been updated to use a matrix field instead of this import parameter, what are the implications of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main implication is that
push-post-statecan't be set from manual workflow_dispatch anymore you'd have to add it to the JSON config file instead.Scheduled runs still work fine since they read from the JSON anyway.
We had to make this trade-off because GitHub has a 10 input limit for workflow_dispatch, and we needed room for
firewood-refandlibevm-ref. Figured those are more useful for manual runs (testing custom versions), whilepush-post-stateis typically used in scheduled/automated runs anyway.If you ever need to manually push state after a run, you can still do it with:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronbuchwald Thoughts?