-
Notifications
You must be signed in to change notification settings - Fork 841
Pass block tracker in deserialize block #4266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes nil pointer exceptions in block deserialization by ensuring the blockTracker is properly passed to the deserializer. This addresses missing blockTracker initialization that was causing runtime failures when deserializing blocks.
- Updates blockDeserializer to include a blockTracker field
- Modifies DeserializeBlock to use newBlock() instead of direct Block struct creation
- Adds test verification to ensure deserialized blocks can be properly verified
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| simplex/block.go | Adds blockTracker field to blockDeserializer and updates DeserializeBlock to use newBlock() |
| simplex/block_test.go | Updates test to initialize blockTracker in deserializer and adds verification test |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Why this should be merged
Not having passing the blockTracker while deserializing a block causes nil pointer exceptions.
How this works
How this was tested
Need to be documented in RELEASES.md?